Skip to content

[Validator] Add missing types and return types #18570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2023
Merged

[Validator] Add missing types and return types #18570

merged 1 commit into from
Jul 17, 2023

Conversation

alexandre-daubois
Copy link
Member

Follow-up of #18568

Also the first parameter of ConstraintValidator::validate() has been renamed to $value instead of $object, I updated the few places I could find it appears 🙂

@carsonbot carsonbot added this to the 6.2 milestone Jul 17, 2023
@javiereguiluz
Copy link
Member

Alex, thanks so much for adding new types continuously!

@javiereguiluz javiereguiluz merged commit 49888ee into symfony:6.2 Jul 17, 2023
@alexandre-daubois alexandre-daubois deleted the types-automapping branch July 17, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@94noni 94noni 94noni approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @javiereguiluz @94noni @carsonbot