Fix operator to assign the route name micro_kernel_trait.rst #18577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IssamRaouf
changed the title
|
@IssamRaouf very good catch! Thanks and congrats on your first Symfony Docs contribution 🎉 |
javiereguiluz
added a commit
that referenced
this pull request
Jul 18, 2023
….rst (IssamRaouf) This PR was submitted for the 6.4 branch but it was merged into the 6.2 branch instead. Discussion ---------- Fix operator to assign the route name micro_kernel_trait.rst The operator to assign the route name should be ':' instead of "=" <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 818f0e1 Update micro_kernel_trait.rst
|
@IssamRaouf please note that while merging your Pull Request, I changed the branch from I did that with the proprietary tool that we use to merge Pull Requests. It worked as expected and your contribution appears in the log of commits of
However, for some reason, GitHub decided to display this Pull Request as "closed" instead of "merged" ... but, it's "merged". Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator to assign the route name should be ':' instead of "="