Skip to content

[Config] Update definition.rst #18579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Config] Update definition.rst #18579

merged 1 commit into from
Jul 20, 2023

Conversation

JuGid
Copy link
Contributor

@JuGid JuGid commented Jul 17, 2023

Always acting as a trap for me : the configuration processor consider the root node (TreeBuilder "name") already stripped off. Always wanted to add documentation about it and never found out where to find this information.

.. caution::

When processing the configuration tree, the processor assumes the top level
array key is already stripped off. If you want a root name, you should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need that second sentence as it may bring more confusion.

Suggested change
array key is already stripped off. If you want a root name, you should
array key (a.k.a the extension name) is already stripped off.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this change while merging. Thanks!

@carsonbot carsonbot changed the title Update definition.rst [Config] Update definition.rst Jul 20, 2023
@javiereguiluz javiereguiluz added this to the 5.4 milestone Jul 20, 2023
@javiereguiluz javiereguiluz changed the base branch from 6.3 to 5.4 July 20, 2023 11:24
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner July 20, 2023 11:24
@javiereguiluz javiereguiluz merged commit f9ba396 into symfony:5.4 Jul 20, 2023
@javiereguiluz
Copy link
Member

This is now merged. Julien, thanks and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants