Skip to content

[Intl] Document support for ISO 3166-1 numeric codes #18610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

benr77
Copy link
Contributor

@benr77 benr77 commented Jul 25, 2023

@carsonbot carsonbot added this to the 6.4 milestone Jul 25, 2023
@javiereguiluz javiereguiluz added Waiting Code Merge Docs for features pending to be merged Intl labels Jul 26, 2023
@carsonbot carsonbot changed the title Document support for ISO 3166-1 numeric codes [Intl] Document support for ISO 3166-1 numeric codes Jul 26, 2023
@carsonbot carsonbot modified the milestones: 6.4, next Jul 26, 2023

$exists = Countries::numericCodeExists('250');
// => true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new feature, we must add a note like the following:

.. versionadded:: 6.4

    The support for numeric country codes was introduced in Symfony 6.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben, thanks for contributing this feature and the docs for it. Let's wait for the code merge so we can merge this one too.

@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Aug 2, 2023
@javiereguiluz javiereguiluz modified the milestones: next, 6.4 Aug 2, 2023
@javiereguiluz javiereguiluz merged commit 2653ef4 into symfony:6.4 Aug 2, 2023
@javiereguiluz
Copy link
Member

Thanks Ben!

While merging, I decided to add some context information (from the Uncyclopedia link that you included) about why these numeric codes might be useful: 518e596

@benr77 benr77 deleted the patch-1 branch August 2, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants