Skip to content

[DomCrawler][FrameworkBundle] Add assertAnySelectorText* #18704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alamirault
Copy link
Contributor

Fix #18699

@carsonbot carsonbot added this to the 6.4 milestone Aug 5, 2023
@alamirault alamirault changed the title [DomCrawler][FrameworkBundle] Add assertAnySelectorText* [DomCrawler][FrameworkBundle] Add assertAnySelectorText* Aug 5, 2023
javiereguiluz added a commit that referenced this pull request Aug 7, 2023
…on (alamirault)

This PR was merged into the 6.3 branch.

Discussion
----------

[Testing] Fix Crawler assertSelectorTextSame documentation

Method `assertSelectorTextNotSame` does not exist, so we must not add this text

(Found when working on #18704)

Commits
-------

70499a8 Fix Crawler assertSelectorTextSame documentation
@javiereguiluz javiereguiluz force-pushed the feature/18699-assert-any-selector branch from 379b102 to c20766f Compare August 7, 2023 07:20
@javiereguiluz
Copy link
Member

And another nice contribution! Thanks Antoine.

@javiereguiluz javiereguiluz merged commit 328e872 into symfony:6.4 Aug 7, 2023
@alamirault alamirault deleted the feature/18699-assert-any-selector branch August 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DomCrawler][FrameworkBundle] Add assertAnySelectorText*
3 participants