Add a note about Mock classes not considered for security issues #18730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 10, 2023
derrabus
reviewed
Aug 10, 2023
| @@ -21,6 +21,10 @@ email for confirmation): | |||
| production (including the web profiler or anything enabled when ``APP_DEBUG`` | |||
| is set to ``true`` or ``APP_ENV`` set to anything but ``prod``); | |||
|
|
|||
| * Any security issues found in classes provided to help fo testing that should | |||
There was a problem hiding this comment.
Suggested change
| * Any security issues found in classes provided to help fo testing that should | |
| * Any security issues found in classes provided for testing that should |
There was a problem hiding this comment.
Fixed while merging. Thanks.
stof
reviewed
Aug 10, 2023
| @@ -21,6 +21,10 @@ email for confirmation): | |||
| production (including the web profiler or anything enabled when ``APP_DEBUG`` | |||
| is set to ``true`` or ``APP_ENV`` set to anything but ``prod``); | |||
|
|
|||
| * Any security issues found in classes provided to help fo testing that should | |||
| never be used in production (like for instance mock classes that contain | |||
| ``Mock`` in their name); | |||
There was a problem hiding this comment.
I suggest mentioning the Test namespace as well inside those braces.
There was a problem hiding this comment.
Added while merging. See ea432f9 Thanks.
|
Thanks Fabien! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.