Skip to content

[Flex] Remove PHP<8 section, remove flex reference #18782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

kaznovac
Copy link
Contributor

  • symfony 6.x requires php > 8 so configuration section for pre 8 is irrelevant
  • dotenv:dump has been implemented in 5.4 and reference to flex is no longer relevant symfony/symfony@234c0b3

@kaznovac
Copy link
Contributor Author

Is there a concrete reason why the dotenv:dump is not auto-registered?
Feels odd to manually register command marked as @internal

@94noni
Copy link
Contributor

94noni commented Aug 24, 2023

What/where the git blame shows/points to?

Perhaps because the component is not mandatory if devs use env vars without the dotenv component being installed in the project

@carsonbot carsonbot changed the title [configuration]: remove php<8 section, remove flex reference [Flex] [configuration]: remove php<8 section, remove flex reference Oct 29, 2023
@OskarStark OskarStark changed the title [Flex] [configuration]: remove php<8 section, remove flex reference [Flex] Remove PHP<8 section, remove flex reference Oct 29, 2023
@OskarStark OskarStark added this to the 6.3 milestone Oct 29, 2023
- symfony 6.x requires php > 8 so configuration section for pre 8 is irrelevant
- `dotenv:dump` has been implemented in 5.4 and reference to flex is no longer relevant symfony/symfony@234c0b3
@OskarStark OskarStark force-pushed the kaznovac-configuration branch from 2b3aa72 to 8bccba6 Compare October 29, 2023 07:54
@OskarStark
Copy link
Contributor

OskarStark commented Oct 29, 2023

Thank you Marko, I fixed the conflicts while merging 👍

@OskarStark OskarStark merged commit c7493e0 into symfony:6.3 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants