[Mailer] Embedding images support custom cid #18817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
force-pushed
the
feature/17703-cid
branch
from
3fd8de6 to
cee2e96
Compare
carsonbot
changed the title
carsonbot
changed the title
|
Antoine, thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17703
It was complicated to me to understand well PR and use case, as it's very specific and can be considered as a bugfix, but it's was e feature.
Example of use case:
We send an Email with
Partsand html with cid (human friendly name is replaced by generated cid). We want to forward this email, so we keep the same html (with generated cid) andPartsare rebuild with generated cid (setContentId).Now it works (cid are kept), but before it was ko