Skip to content

[Console] Mention Terminal #18916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

[Console] Mention Terminal #18916

merged 1 commit into from
Sep 22, 2023

Conversation

alexandre-daubois
Copy link
Member

Fix #17781

@alexandre-daubois alexandre-daubois mentioned this pull request Sep 22, 2023
Merged
@OskarStark
Copy link
Contributor

Can we add a versionadded?

@alexandre-daubois
Copy link
Member Author

Actually, the Terminal class seems to be present since at least 3.4

@javiereguiluz javiereguiluz added this to the 5.4 milestone Sep 22, 2023
@javiereguiluz javiereguiluz merged commit 1b63db6 into symfony:5.4 Sep 22, 2023
@javiereguiluz
Copy link
Member

Thanks a lot Alex!

While merging I removed the last phrase:

By default, the ``Terminal`` class uses the values of the
``LINES`` and ``COLUMNS`` system environment variables.

I did that because the source code of Terminal is pretty complex and LINES/COLUMNS env vars are only the first thing it checks ... but it also checks many other things. So, it's an advanced logic and this phrase might by a bit misleading. Thanks.

@javiereguiluz javiereguiluz mentioned this pull request Sep 22, 2023
Closed
javiereguiluz added a commit that referenced this pull request Sep 22, 2023
@javiereguiluz
minor #18917 [Console] Mention Terminal color mode support (alexand…
8d25104 
…re-daubois)

This PR was merged into the 6.3 branch.

Discussion
----------

[Console] Mention `Terminal` color mode support

Requires
* #18916

Commits
-------

76c03ac [Console] Mention `Terminal` color mode support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @OskarStark @javiereguiluz