Skip to content

[Console] link Symfony default style doc page on coloring doc page #19044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Oct 18, 2023

I think it may help, wdyt?

the edited file appears on top of the TOC of the console page, where the linked page appears far at bottom
show casing that Symfony already has this done is relevant (think of the abstract controller is documented when documenting controller)

@OskarStark
Copy link
Contributor

I would move this tip to the top

@94noni
Copy link
Contributor Author

94noni commented Oct 18, 2023

@OskarStark oki, lets wait other review to see where is the best spot for this tip, and of course if the tip is relevant at all here
thx!

@94noni 94noni changed the title link symfony default style on coloring documentation [Console] link Symfony default style doc page on coloring doc page Oct 24, 2023
@javiereguiluz javiereguiluz merged commit 9e30c21 into symfony:6.3 Nov 21, 2023
@javiereguiluz
Copy link
Member

I agree with Oskar. While merging, I reworded this into the introduction of the article. See dc57a9f

In any case, this was a very nice proposal. Thanks Antoine!

@94noni 94noni deleted the patch-10 branch November 21, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants