Skip to content

Chore: Fix typo in multiple files #19058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

Chore: Fix typo in multiple files #19058

merged 1 commit into from
Oct 20, 2023

Conversation

thapasusheel
Copy link
Contributor

@thapasusheel thapasusheel commented Oct 20, 2023 •
edited by OskarStark
Loading

This PR fix the typo seen in various files

esimated >estimated
strengh > strength
mehtod > method
contraints > constraints
instanciation > instantiation

@thapasusheel thapasusheel requested a review from xabbuh as a code owner October 20, 2023 02:20
@carsonbot carsonbot added this to the 6.4 milestone Oct 20, 2023
@OskarStark
Copy link
Contributor

@alamirault we should add them to the typo rule I guess

The only thing I don't agree is:
instanciation

It should be instatiantion

@thapasusheel
Copy link
Contributor Author

@alamirault we should add them to the typo rule I guess

The only thing I don't agree is: instanciation

It should be instatiantion

Thanks you for finding out by shortcoming in the comment.

@OskarStark
Copy link
Contributor

OskarStark commented Oct 20, 2023 •
edited
Loading

Thank you Susheel and congrats on your first contribution to the Symfony documentation 🎉

@OskarStark OskarStark merged commit 9901e18 into symfony:6.4 Oct 20, 2023
@alamirault alamirault mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@thapasusheel @OskarStark @carsonbot