Skip to content

[Webhook] Added Sendgrid's webhook support (added in 6.4) #19267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[Webhook] Added Sendgrid's webhook support (added in 6.4) #19267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion webhook.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Webhook

.. versionadded:: 6.3

The Webhook component was introduced in Symfony 6.3
The Webhook component was introduced in Symfony 6.3.

The Webhook component is used to respond to remote webhooks to trigger actions
in your application. This document focuses on using webhooks to listen to remote
Expand Down Expand Up @@ -84,8 +84,14 @@ Mailer service Parser service name
=============== ==========================================
Mailgun ``mailer.webhook.request_parser.mailgun``
Postmark ``mailer.webhook.request_parser.postmark``
Sendgrid ``mailer.webhook.request_parser.sendgrid``
=============== ==========================================

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a versionadded for Mailgun and Postmark too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a third column, perhaps? To have a bit better overview when more are added in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we usually remove the versionadded directives when merging up to a new major, so we should stick with this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Webhook itself is covered by a 6.3 versionadded in the top of the document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this in the PR of Alex #19268

.. versionadded:: 6.4

Webhook support for the Sendgrid service was introduced in Symfony 6.4.


Set up the webhook in the third-party mailer. For Mailgun, you can do this
in the control panel. As URL, make sure to use the ``/webhook/mailer_mailgun``
path behind the domain you're using.
Expand Down