Skip to content

[Notifier] Note about message bus usage in notification component #19297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

cancelledbit
Copy link
Contributor

Previously, the documentation did not specify that if a MessageBus exists, messages are unconditionally sent through it. This leads to problems when you do not have a message consumer running

@carsonbot carsonbot added this to the 6.4 milestone Dec 16, 2023
@cancelledbit cancelledbit changed the title Note about message bus usage in notification component [Notifier] Note about message bus usage in notification component Dec 16, 2023
@OskarStark
Copy link
Contributor

@fabpot that makes me think about making this option opt-in instead of opt-out 🤔

@javiereguiluz javiereguiluz changed the base branch from 6.4 to 6.3 January 17, 2024 14:07
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner January 17, 2024 14:07
@javiereguiluz javiereguiluz merged commit cb9c808 into symfony:6.3 Jan 17, 2024
@javiereguiluz
Copy link
Member

@cancelledbit thanks ... and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants