[String] Remove confusing paragraph about withEmoji('strip')
#19323
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
withEmoji('strip')
|
But afterwards there is no mention about I am for keeping it and change it to remove potentially confusion |
|
If it's changed and moved outside the Slugger section i agree :) |
wouterj
requested changes
Dec 23, 2023
There was a problem hiding this comment.
We should move this paragraph+example to https://symfony.com/doc/current/components/intl.html#emoji-transliteration (on branch 6.3)
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
javiereguiluz
force-pushed
the
patch-4
branch
from
153ce1e to
9f4b626
Compare
|
Good catch, thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsciiSlugger does remove every emoji from a given string per default without any external component or package, as they are not... ASCII.
The paragraph added some confusion to the reader, implying that
So i suggest to purely remove it.