Skip to content

[Emoji] Emoji component #19489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Feb 3, 2024

Emoji documentation

(Issue: #19484)

@carsonbot carsonbot added this to the 7.1 milestone Feb 3, 2024
@smnandre smnandre marked this pull request as draft February 3, 2024 15:00
@smnandre smnandre changed the title Emoji component [WIP] Emoji component Feb 16, 2024
@smnandre smnandre marked this pull request as ready for review February 16, 2024 08:24
@xabbuh xabbuh added the Emoji label Feb 16, 2024
@carsonbot carsonbot changed the title Emoji component [Emoji] Emoji component Feb 16, 2024
@smnandre
Copy link
Member Author

Run ../_checker/code-block-checker.php verify:docs `pwd` components/emoji.rst components/intl.rst  --baseline=baseline.json --output-format=github --symfony-application=`realpath ../_sf_app`

Error: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not exist
Error: [Missing class] Class, interface or trait with name "Symfony\Component\Emoji\EmojiTransliterator" does not exist
Error: Process completed with exit code 1.

Does that mean Emoji component must be added to the symfony app ?

@smnandre
Copy link
Member Author

Thank you for the feedback @javiereguiluz !

The CI stays red (will stay red until we add "emoji" to the stimulus app used in this CI workflow i think)

Anything i can add / imrpove ?

@javiereguiluz javiereguiluz merged commit 48c932d into symfony:7.1 Mar 11, 2024
@javiereguiluz
Copy link
Member

Simon, thanks a lot for this 🙌 This is now merged!

Note that while merging we reorganized contents a bit. We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs under components/ namespace. We want to remove all components/ docs and move it to normal articles. So, we've deleted components/emoji.rst and moved its contents to components/string.rst (see 9333df7). In a future PR we're going to move components/string.rst to string.rst. Thanks!

@smnandre
Copy link
Member Author

We discussed internally in the Symfony Docs team and decided to do so because we don't want to add new docs under components/ namespace.

Ok noted for the future

Note that while merging we reorganized contents a bit.

Thanks for the heads up and explanation! Makes a lot of sense :)

javiereguiluz added a commit that referenced this pull request Mar 14, 2024
…iluz)

This PR was merged into the 7.1 branch.

Discussion
----------

[String] Reorganize String component contents

As mentioned in #19489, we want to move contents out from `components/`. This PR moves String to its own root-level article.

Commits
-------

d4aed27 [String] Reorganize String component contents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants