Skip to content

[Config] be more specific about bool env var processor #19573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Feb 20, 2024
Merged

[Config] be more specific about bool env var processor #19573

merged 1 commit into from Feb 20, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2024

Previous wording was not accurate enough for me because only 0 and 0.0 as integer and float respectively was presented. Alternative change could be:

and all numbers except 0, 0.0, '0' and '0.0'

Let me know if the latter fits better for you.

@carsonbot carsonbot changed the title be more specific about bool env var processor [Config] be more specific about bool env var processor Feb 20, 2024
@javiereguiluz javiereguiluz added this to the 6.4 milestone Feb 20, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.0 to 6.4 February 20, 2024 07:42
@javiereguiluz javiereguiluz merged commit 8e3a0f4 into symfony:6.4 Feb 20, 2024
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 20, 2024

I agree that we need to be more precise about this. In fact, while merging, I expanded your contribution a bit to include the examples that you mentioned in the description. See 85ba363

In any case, thanks a lot and congrats on your first Symfony Docs contribution 🎉

@ghost ghost deleted the patch-1 branch February 20, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants