Replace old docker compose filename #19582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-compose.yml/yaml to compose.yaml
maxhelias
approved these changes
Feb 21, 2024
OskarStark
reviewed
Feb 22, 2024
| @@ -93,6 +93,7 @@ whitelist: | |||
| - '/``.yml``/' | |||
| - '/(.*)\.orm\.yml/' # currently DoctrineBundle only supports .yml | |||
| - /docker-compose\.yml/ | |||
There was a problem hiding this comment.
this can be removed then
OskarStark
reviewed
Feb 22, 2024
| @@ -93,6 +93,7 @@ whitelist: | |||
| - '/``.yml``/' | |||
| - '/(.*)\.orm\.yml/' # currently DoctrineBundle only supports .yml | |||
| - /docker-compose\.yml/ | |||
| - /compose\.yaml/ | |||
There was a problem hiding this comment.
this should not be needed
There was a problem hiding this comment.
i'm not aware of what this file is doing, can you explain it to me ?
There was a problem hiding this comment.
Sure this list is to suppress a warning by out linter, but as this line will not produce this error anymore it can be removed
wouterj
approved these changes
Feb 25, 2024
|
@Xbirdfr thanks ... and congrats on your first Symfony Docs contribution 🎉 |
|
Note: I merged this in 7.1 because I missed that reviewers suggested to merge this in 5.4 and up. But, later, I backported these changes to 5.4 and all the other branches. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace old docker compose filename from
docker-compose.yml/yaml
to
compose.yaml