chore: add the request/response/exception flow diagram to showcase events #19603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Feb 26, 2024
… (94noni) This PR was merged into the 5.4 branch. Discussion ---------- chore: replace `workflow` by `flow` and add more context idea: add more context that its a request/response logic (actually we read more request than response) swap the word workflow to flow (ref #19603 and the kernel flow) Commits ------- 42c8fd9 chore: replace `workflow` by `flow` and add more context
|
I like this idea ... but the problem is that the image shown here (https://symfony.com/doc/current/_images/components/http_kernel/http-workflow-exception.svg) doesn't display any events and it has some numbered callouts (1, 2, 3, ...) that don't make sense in this page (in the other page where this image is included, we explain each of these numbered items). |
|
that was my initial thought as well |
|
stale, lets close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagram can be found deep in https://symfony.com/doc/current/components/http_kernel.html#handling-exceptions-the-kernel-exception-event
to me, it is very interesting to represent in the head/mind the flow, just before reading all the internals symfony events
wdyt?