Fixes async cache computation example and FQCN #19678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvhirsch
changed the title
mvhirsch
changed the title
OskarStark
approved these changes
Mar 16, 2024
carsonbot
changed the title
|
@javiereguiluz this can be merged IMHO |
|
Oskar, I trust you, so let's merge this. Thanks Michael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes invalid documentation. Took me an hour to figure it out. Thankfully, every new feature gets a blog post (thx @nicolas-grekas): https://symfony.com/blog/new-in-symfony-5-2-async-cache-recomputing
I'll provide another MR with a working example using a DI service (needs
CallbackInterfaceor service must be public).