[Security] Update OidcTokenHandler dependencies and configuration
#19779
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the individual jwt packages previously needed by 'OidcTokenHandler' with the `web-token/jwt-library`. Configuration changes have been made to support multiple signing algorithms and a keyset instead of a single key. These changes provide more flexibility and reliability for token handling and verification.
OskarStark
changed the title
OidcTokenHandler dependencies and configuration
OskarStark
reviewed
Apr 19, 2024
| The ``OidcTokenHandler`` requires ``web-token/jwt-signature``, | ||
| ``web-token/jwt-checker`` and ``web-token/jwt-signature-algorithm-ecdsa`` | ||
| packages. If you haven't installed them yet, run these commands: | ||
| The ``OidcTokenHandler`` requires the package ``web-token/jwt-library``. |
There was a problem hiding this comment.
Suggested change
| The ``OidcTokenHandler`` requires the package ``web-token/jwt-library``. | |
| The ``OidcTokenHandler`` requires the ``web-token/jwt-library`` package:: |
There was a problem hiding this comment.
I did this change while merging.
OskarStark
reviewed
Apr 19, 2024
| ``web-token/jwt-checker`` and ``web-token/jwt-signature-algorithm-ecdsa`` | ||
| packages. If you haven't installed them yet, run these commands: | ||
| The ``OidcTokenHandler`` requires the package ``web-token/jwt-library``. | ||
| If you haven't installed it yet, run this command: |
There was a problem hiding this comment.
Suggested change
| If you haven't installed it yet, run this command: |
There was a problem hiding this comment.
I didn't do this change because in other parts of this document we use the same expression. I think that being so explicit makes things very clear.
OskarStark
approved these changes
Apr 19, 2024
|
One question, before 7.1 it worked with one and now with more. Shall we add sth like: ? |
|
Thanks Florent! Oskar, I also added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19740
This commit replaces the individual jwt packages previously needed by 'OidcTokenHandler' with the
web-token/jwt-library. Configuration changes have been made to support multiple signing algorithms and a keyset instead of a single key. These changes provide more flexibility and reliability for token handling and verification.