-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Mercure] fix service definition example in testing section #20040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
note: the mercure bundle then wraps this in a
should i add this instead of the simple syntax fix? furthermore,
my workaround for that was to add a parameter in services_test.yaml:
i assume this is a common issue. i don't know if there is a better solution, but ideally the guide would be complete to produce a working result without having to figure out these things. should i add this or something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good catch
Thanks David. |
@xabbuh thanks. what do you think about expanding the section a bit, as the env variable check broke tests for me and one can not access the stub service like this? |
@dbu I am not completely if I understand what you have in mind. Can you give an example? |
i tried to explain in #20040 (comment) : when i follow the documentation, flex configures an env variable MERCURE_PUBLIC_URL for me, and when i overwrite the hub default service, i get that error and the other thing would be to explain how to configure the service to actually be able to access it in my test to see what it received, because the service is being decorated. (though that maybe would better be a link as its not about the mercure component but about working with services in general) |
Tried to follow the example and noticed that this was wrong