[DomCrawler] fixes typo Form::getFields() -> Form::getFiles()
#20077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
Form::getFields()Form::getFields()
OskarStark
changed the title
Form::getFields()Form::getFields()
|
Wonder if this was not supposed to be |
Maybe yes. Should I just rename instead of removing it @smnandre ? |
|
renaming |
mvhirsch
changed the title
Form::getFields()Form::getFields() -> Form::getFiles())
mvhirsch
changed the title
Form::getFields() -> Form::getFiles())Form::getFields() -> Form::getFiles()
xabbuh
approved these changes
Aug 6, 2024
OskarStark
approved these changes
Aug 6, 2024
xabbuh
force-pushed
the
bugfix/removes-mention
branch
from
fb3498d to
8cfb8e0
Compare
|
Good catch, thanks @mvhirsch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this method does not exist in
Form: https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/DomCrawler/Form.phpI think it never did. Looking at v2.8 it does not exist, same's true for 3.4, 4.4, 5.4, 6.4, 7.0 ...