Skip to content

[Serializer] Correction of examples using the attributes groups #20155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lkolndeep
Copy link
Contributor

A correction of two examples of denormalization operations using the attribute groups.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that technically there is no difference as the example seems to assume that MyObj is part of the global namespace

@lkolndeep
Copy link
Contributor Author

note that technically there is no difference as the example seems to assume that MyObj is part of the global namespace

Hello @xabbuh,

In the MyObj class, there is namespace Acme;.
That is why, to avoid any confusion, I think, it is a better to use MyObj::class.

Thanks for your feedback!

Regards,

@xabbuh
Copy link
Member

xabbuh commented Aug 25, 2024

Looks like we should add a use statement for the class then.

@javiereguiluz
Copy link
Member

Thank you Stephan.

@javiereguiluz javiereguiluz merged commit ce1981e into symfony:5.4 Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants