Skip to content

Fix typos in end_to_end.rst #20177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions testing/end_to_end.rst
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ to install ChromeDriver and geckodriver locally:

$ vendor/bin/bdi detect drivers

Panther will detect and use automatically drivers stored in the ``drivers/`` directory
Panther will detect and automatically use drivers stored in the ``drivers/`` directory
of your project when installing them manually. You can download `ChromeDriver`_
for Chromium or Chromeand `GeckoDriver`_ for Firefox and put them anywhere in
for Chromium or Chrome and `GeckoDriver`_ for Firefox and put them anywhere in
your ``PATH`` or in the ``drivers/`` directory of your project.

Alternatively, you can use the package manager of your operating system
Expand Down Expand Up @@ -132,7 +132,7 @@ Creating a TestCase
~~~~~~~~~~~~~~~~~~~

The ``PantherTestCase`` class allows you to write end-to-end tests. It
automatically starts your app using the built-in PHP web server and let
automatically starts your app using the built-in PHP web server and lets
you crawl it using Panther. To provide all the testing tools you're used
to, it extends `PHPUnit`_'s ``TestCase``.

Expand Down Expand Up @@ -264,8 +264,7 @@ future::
}
}

You can then run this test by using PHPUnit, like you would do for any other
test:
You can then run this test using PHPUnit, like you would for any other test:

.. code-block:: terminal

Expand Down Expand Up @@ -498,13 +497,13 @@ Having a Multi-domain Application
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It happens that your PHP/Symfony application might serve several different
domain names. As Panther saves the Client in memory between tests to improve
domain names. As Panther saves the client in memory between tests to improve
performance, you will have to run your tests in separate
processes if you write several tests using Panther for different domain names.

To do so, you can use the native ``@runInSeparateProcess`` PHPUnit annotation.
Here is an example using the ``external_base_uri`` option to determine the
domain name used by the Client when using separate processes::
domain name used by the client when using separate processes::

// tests/FirstDomainTest.php
namespace App\Tests;
Expand Down Expand Up @@ -792,7 +791,7 @@ The following features are not currently supported:
* Selecting invalid choices in select

Also, there is a known issue if you are using Bootstrap 5. It implements a
scrolling effect, which tends to mislead Panther. To fix this, we advise you to
scrolling effect which tends to mislead Panther. To fix this, we advise you to
deactivate this effect by setting the Bootstrap 5 ``$enable-smooth-scroll``
variable to ``false`` in your style file:

Expand Down
Loading