Skip to content

[Translation] fix: add nikic/php-parser requirement for translation:extract in tran… #20182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bsramin
Copy link
Contributor

@bsramin bsramin commented Aug 31, 2024

…slation.rst

@bsramin
Copy link
Contributor Author

bsramin commented Aug 31, 2024

@MrYamous
Copy link
Contributor

MrYamous commented Sep 2, 2024

Can be applied on 6.4 too I think

translation.rst Outdated
@@ -457,6 +457,16 @@ The ``translation:extract`` command looks for missing translations in:
* Any PHP file/class stored in the ``src/`` directory that uses
:ref:`Constraints Attributes <validation-constraints>` with ``*message`` named argument(s).

To read PHP files, is used the new ``PhpAstExtractor`` service supports all kinds of trans() function calls, usages of TranslatableMessage class, messages defined in validation constraints, etc...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may can add a .. versionadded:: 6.2 directive if applied on 6.4 branch

@javiereguiluz javiereguiluz added this to the 6.4 milestone Sep 2, 2024
@carsonbot carsonbot changed the title fix: add nikic/php-parser requirement for translation:extract in tran… [Translation] fix: add nikic/php-parser requirement for translation:extract in tran… Sep 2, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.1 to 6.4 September 2, 2024 10:25
@javiereguiluz javiereguiluz merged commit 5d29c31 into symfony:6.4 Sep 2, 2024
3 checks passed
@javiereguiluz
Copy link
Member

@bsramin this is now merged! Thanks ... and congrats on your first Symfony Docs contribution 🎉

Note that while merging we did some reword (see ad92626). Don't worry, this is normal for Symfony Docs contributions. We do that to ensure that all docs have the same tone and style.

In this case, we moved the new docs to a .. tip directive to make it stand out. Also, we removed some of the most technical details because that might be OK for a blog post but it's a little too much detail for the docs.

In any case, thanks again for your contribution!

@bsramin bsramin deleted the patch-1 branch September 2, 2024 10:35
@bsramin
Copy link
Contributor Author

bsramin commented Sep 2, 2024

Thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants