-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Translation] fix: add nikic/php-parser requirement for translation:extract in tran… #20182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Find this from this blog news https://symfony.com/blog/new-in-symfony-6-2-better-php-translation-extractor |
Can be applied on 6.4 too I think |
translation.rst
Outdated
@@ -457,6 +457,16 @@ The ``translation:extract`` command looks for missing translations in: | |||
* Any PHP file/class stored in the ``src/`` directory that uses | |||
:ref:`Constraints Attributes <validation-constraints>` with ``*message`` named argument(s). | |||
|
|||
To read PHP files, is used the new ``PhpAstExtractor`` service supports all kinds of trans() function calls, usages of TranslatableMessage class, messages defined in validation constraints, etc... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may can add a .. versionadded:: 6.2
directive if applied on 6.4 branch
772eb1c
to
9041d05
Compare
@bsramin this is now merged! Thanks ... and congrats on your first Symfony Docs contribution 🎉 Note that while merging we did some reword (see ad92626). Don't worry, this is normal for Symfony Docs contributions. We do that to ensure that all docs have the same tone and style. In this case, we moved the new docs to a In any case, thanks again for your contribution! |
Thanks 👍🏻 |
…slation.rst