[Messenger] Add reference to PHP docs for SSL context options #20325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
messenger_redis_ssl
branch
from
191b970 to
f39f657
Compare
MrYamous
reviewed
Oct 15, 2024
| @@ -1694,7 +1694,7 @@ redis_sentinel support is disabled | |||
| ssl Map of TLS options. null | |||
| ======================= ===================================== ================================= | |||
|
|
|||
| The ``ssl`` option can be used to change requirements for the TLS channel, e.g. in tests: | |||
| The ``ssl`` option can be used to provide SSL context options (`php.net/context.ssl`_) for the TLS channel, e.g. in tests: | |||
There was a problem hiding this comment.
Suggested change
| The ``ssl`` option can be used to provide SSL context options (`php.net/context.ssl`_) for the TLS channel, e.g. in tests: | |
| The ``ssl`` option can be used to provide `SSL context options`_ for the TLS channel, e.g. in tests: |
WDYT about this for better link integration in text ?
There was a problem hiding this comment.
I think we could use the proposed variant if this keeps the reference intact to the PHP docs.
See:
|
Thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #20094 (comment).