Skip to content

[Templating] : Adding named attribute arguments #21023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open

[Templating] : Adding named attribute arguments #21023

wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

Page: https://symfony.com/doc/current/templates.html#create-the-extension-class

Isn't there a best practice somewhere to always pass the parameter's name explicitly?

@ThomasLandauer
[Templating]: Adding named attribute arguments
9f19007 
Page: https://symfony.com/doc/current/templates.html#create-the-extension-class

Isn't there a best practice somewhere to always pass the name explicitly?
@carsonbot carsonbot changed the title [Templating]: Adding named attribute arguments [Templating] : Adding named attribute arguments May 30, 2025
javiereguiluz
javiereguiluz reviewed Jun 3, 2025
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not add the argument name explicitly in these examples because, in my opinion, the code is already clear and self-explanatory.

@javiereguiluz javiereguiluz added this to the 7.3 milestone Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

Assignees
No one assigned
Labels
Status: Needs Review Templating
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @javiereguiluz @carsonbot