Fix typo in documentation: changed "controller" to "number" method #21053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the line that incorrectly instructed to create a "controller" method. Replaced it with "number" method to align with the actual example context. Original: To do that, create a "Controller" class and a "controller" method inside of it: Updated: To do that, create a "Controller" class and a "number" method inside of it:
|
Thanks @deekumar24! We merged your other PR #21052 which fixed this in a lower branch. When merging changes, we "upmerge" them in all supported branches automatically. So, the change you made in #21052 is also merged into 8.0 branch and there's no need to merge this PR too. That's why we're closing it without merge. The general rule (for both code and docs) is that bugs should only be fixed in the oldest maintained branch that contains the error. See also https://symfony.com/releases#maintained-symfony-branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the line that incorrectly instructed to create a "controller" method. Replaced it with "number" method to align with the actual example context.
Original:
To do that, create a "Controller" class and a "controller" method inside of it:
Updated:
To do that, create a "Controller" class and a "number" method inside of it: