add format to Min Constraint and some minor unification of dots and quotes #2213
Conversation
Conflicts: reference/forms/types/collection.rst reference/twig_reference.rst
Document the mapped form type option
Added note about Service Container parameters inside routes
DataEvent is deprecated since 2.1, to be removed in 2.3.
Changing the getVar method to get (only valid for 2.1)
Conflicts: book/controller.rst book/forms.rst cookbook/map.rst.inc
Remove reference to deprecated DataEvent and FilterDataEvent
This only include minor changes.
Typo in documentation that would cause an exception. setContent can not accept array. Assuming documentation meant setData.
Update components/http_foundation/introduction.rst
Update reference/constraints/Callback.rst (dont use deprecated method)
[DI] PrependExtensionInterface sync doc with latest Sf2 changes
sf2.2 note: _method override disabled by default
…cation updated render usage
Conflicts: book/installation.rst
Improving the documentation for ``session`` according to the Configuration file (https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L192)
Adding versionadded
Conflicts: cookbook/security/entity_provider.rst
|
@ricardclaue, I am really sorry for this, but I already added these formats in a PR (I have cherry pick them in another PR to make it more organized: #2214). The interpuction fixes are good though! |
|
oh sorry :) my fault for not looking at all PR, closing it then! |
|
Oh sorry! Maybe I should not have closed because of the interpuction issues. |
|
@ricarclaue, you can just reopen this PR. Then you go to your local repo and break this commit up into 2 pieces: One commit containing the interpuction fixes and one containing the added formats (in that order). You can read how to do this on stackoverflow. Then you run: This will delete the last commit (which is the commit where you added the formats). So you now have only one commit for the interpuction issues, then do a forced push to github: This should do the trick.
|
|
Sorry about using 2.0 directly. I'll split the commit and redo the PR with just the interpuction (although it is really minor) Let's check my GIT skills with your stackoverflow link and comments! |
|
Wow! I clearly screwed up! Let's close this and start all over :) |
|
@ricardclau, this is not your fault. GitHub don't like these tricks and can get really confused, resulting in PRs like this :) |
|
:) no problem, let's start all over! |
Following @wouterj initiative at #2042 I think this is the only constraint that was missing formats. Also, small unification in terms of quotes and dots at the end.