Skip to content

Fixing wrong parameter name in redirecting in config #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2013

Conversation

michelsalib
Copy link

Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets None

I am also willing to submit an additionnal section on how to redirect to route instead of path with the controller FrameworkBundle:Redirect:redirect. This one is actually using a parameter named route.

@cordoval
Copy link
Contributor

is this for 2.3+ and not for 2.2 ?

@michelsalib
Copy link
Author

No, in all versions of symfony the parameter is named path. As you can see here for 2.2: https://github.com/symfony/symfony/blob/2.2/src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php#L69.
But in the documentation for 2.0 and 2.1, the parameter is the right one. So I pushed for 2.2+.

@wouterj
Copy link
Member

wouterj commented Sep 13, 2013

I am also willing to submit an additionnal section on how to redirect to route instead of path with the controller FrameworkBundle:Redirect:redirect

We already have that in a cookbook article.

@michelsalib
Copy link
Author

@wouterj what we have is the entry I am currently fixing which is how to redirect to path. What I want to write is how to redirect to route.

@xabbuh
Copy link
Member

xabbuh commented Sep 13, 2013

👍 for adding an example for the route redirect.

weaverryan added a commit that referenced this pull request Oct 2, 2013
Fixing wrong parameter name in redirecting in config
@weaverryan weaverryan merged commit 4a0990c into symfony:2.2 Oct 2, 2013
@weaverryan
Copy link
Member

Looks perfect - thanks everyone! And yes, an example with the route would be cool - that'd be an easy win :).

Cheers!

weaverryan referenced this pull request Oct 2, 2013
@michelsalib michelsalib deleted the patch-1 branch October 3, 2013 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants