Skip to content

[Translation] Fix fallback parameter name in the framework config #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2013
Merged

[Translation] Fix fallback parameter name in the framework config #3096

merged 1 commit into from
Nov 3, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Oct 24, 2013

Q A
Doc fix? yes
New docs? no
Applies to -
Fixed tickets -

There is no fallback_locale parameter in the framework configuration, it is called fallback under the translatorconfig parameter. Should it be indicated somehow that fallback is located under translator like translator.fallback? I couldn't find any similar approach though.

weaverryan added a commit that referenced this pull request Nov 3, 2013
[Translation] Fix fallback parameter name in the framework config
@weaverryan weaverryan merged commit d6a93e2 into symfony:2.2 Nov 3, 2013
@weaverryan
Copy link
Member

Hey Philipp!

This is a good fix. I rendered the chapter locally, and the Configuration link points to the top where we have a clear example of exactly how the fallback configuration looks. So, I think we're good - but I'm glad you're thinking about whether or not the reader will have enough information to get his/her job done. Nice work!

Cheers!

@bicpi bicpi deleted the fix_fallback_parameter branch January 5, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants