Skip to content

Improve choice option documentation for entity form field type #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Improve choice option documentation for entity form field type #3098

wants to merge 1 commit into from

Conversation

eikes
Copy link
Contributor

@eikes eikes commented Oct 25, 2013

No description provided.

weaverryan added a commit that referenced this pull request Nov 3, 2013
weaverryan added a commit that referenced this pull request Nov 3, 2013
Biggest thing was to make it clear that choices is a valid thing to set when using the
entity type, but it's not the most common way of providing options.
@weaverryan
Copy link
Member

Hey Eike!

I think telling people how to set the choices option directly for the entity type makes sense, so I've patched your commit into the 2.2 branch at sha: a0b617a and make some further tweaks at sha: e2307a9.

Thanks for your contribution!

@weaverryan weaverryan closed this Nov 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants