Skip to content

fix the XML config and add the corresponding PHP config #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2013
Merged

fix the XML config and add the corresponding PHP config #3206

merged 1 commit into from
Nov 28, 2013

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 18, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

stof
stof reviewed Nov 18, 2013
View reviewed changes
cookbook/logging/channels_handlers.rst
@@ -50,14 +59,32 @@ To do so, just create a new handler and configure it like this:
</monolog:channels>
</monolog:handler>

<monolog:handler name="doctrine" type="stream" path="/var/log/doctrine.log" />
<monolog:handler name="doctrine" type="stream" path="/var/log/doctrine.log">
<monolog:channels>
<type>inclusive</type>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also wrong. It should be a type attribute, not a type child element

@wouterj
Copy link
Member

wouterj commented Nov 18, 2013

the xml does not correspond the Yaml and PHP config at all...

@xabbuh
Copy link
Member Author

xabbuh commented Nov 18, 2013

Hope I fixed all the errors.

Seldaek
Seldaek reviewed Nov 20, 2013
View reviewed changes
cookbook/logging/channels_handlers.rst
<type>exclusive</type>
<channel>doctrine</channel>
<monolog:channels type="exclusive">
<monolog:channel>doctrine</monolog:channel>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be !doctrine, and no type=exclusive

@Seldaek
Copy link
Member

Seldaek commented Nov 20, 2013

Looks good now but fixing the "Yaml specification" paragraph below your changes would be good for clarity as well. I would just wipe this part because it adds confusion and isn't correct:

channels:
    type:     inclusive # Include only those listed below
    elements: [ foo, bar ]
channels:
    type:     exclusive # Include all, except those listed below
    elements: [ foo, bar ]

weaverryan added a commit that referenced this pull request Nov 28, 2013
@weaverryan
Merge pull request #3206 from xabbuh/fix-monolog-config
b5851c7 
fix the XML config and add the corresponding PHP config
@weaverryan weaverryan merged commit b5851c7 into symfony:2.2 Nov 28, 2013
@weaverryan
Copy link
Member

Thanks everyone!

@xabbuh xabbuh deleted the fix-monolog-config branch November 28, 2013 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @wouterj @Seldaek @weaverryan @stof