Skip to content

fixed repeated verb in cookbook/serializer #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

77web
Copy link
Contributor

@77web 77web commented Nov 23, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets n/a

@@ -67,8 +67,8 @@ You can load normalizers and/or encoders by tagging them as
:ref:`serializer.encoder<reference-dic-tags-serializer-encoder>`. It's also
possible to set the priority of the tag in order to decide the matching order.

Here an example on how to load the load
the :class:`Symfony\\Component\\Serializer\\Normalizer\\GetSetMethodNormalizer`:
Here an example on how to load the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be here follows or here is presented

@77web
Copy link
Contributor Author

77web commented Nov 25, 2013

@cordoval
Thank you for review!
But, isn't "here is an example..." enough?
For me, "here follows" or "here is presented" seems too formal. Though I am not a native English speaker...

@cordoval
Copy link
Contributor

@77web as long as you add a missing verb i am fine 👶

@77web
Copy link
Contributor Author

77web commented Nov 25, 2013

@cordoval thank you again! I added "is" there.

@cordoval
Copy link
Contributor

perfect 👶

weaverryan added a commit that referenced this pull request Nov 28, 2013
…ializer

fixed repeated verb in cookbook/serializer
@weaverryan weaverryan merged commit 7a56692 into symfony:2.3 Nov 28, 2013
@weaverryan
Copy link
Member

Thanks for the fix Hiromi!

@77web 77web deleted the fix_repeated_verb_in_cookbook-serializer branch November 28, 2013 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants