[HTTP Cache] typo; improve/simplify code samples; formatting #3350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -716,8 +716,6 @@ request's ``Accept-Encoding`` value. This is done by using the ``Vary`` response | |||
| header, which is a comma-separated list of different headers whose values | |||
| trigger a different representation of the requested resource: | |||
|
|
|||
| .. code-block:: text | |||
There was a problem hiding this comment.
In the beginning of the chapter there is an example for the Cache-Control header, it it using a simple box. But the Vary header example here is using a different format - a text block. So either the Cache-Control example should become a text block or the Vary example should become a normal box. What do you think?
See also my comment in the Conversation tab.
There was a problem hiding this comment.
The simple box actually is a rendered as a blockquote. Thus, I'd change the Cache-Control example since a code block better fits the meaning.
weaverryan
added a commit
that referenced
this pull request
Dec 26, 2013
[HTTP Cache] typo; improve/simplify code samples; formatting
|
All good changes - nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: Changed the formatting of the
Varyheader example according toCache-Control(no code block).