Skip to content

Updated event_listener.rst #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2014
Merged

Updated event_listener.rst #3776

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0127bd2
Updated event_listener.rst
bfgasparin Apr 7, 2014
8e8b8a0
Added Versionadded directive to event_listener.rst
bfgasparin Apr 8, 2014
a6b17a0
Added KernelEvent::isMasterRequest method reference
Apr 10, 2014
4fc3b6a
Fixed internals.rst syntax
bfgasparin Apr 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cookbook/service_container/event_listener.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ done as follow::
{
public function onKernelRequest(GetResponseEvent $event)
{
if (HttpKernel::MASTER_REQUEST != $event->getRequestType()) {
if (false === $event->isMasterRequest()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if (!$event->isMasterRequest()) { to follow the coding standards (we don't do a strict check comparison for methods which already return a boolean, except when we need to distinguish false and 0 for strpos or similar functions)

// don't do anything if it's not the master request
return;
}
Expand All @@ -124,6 +124,10 @@ done as follow::
}
}

.. versionadded:: 2.4
The ``isMasterRequest()`` method was introduced in Symfony 2.4.
Prior, the ``getRequestType()`` method must be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally put these hints above the new feature.


.. tip::

Two types of request are available in the :class:`Symfony\\Component\\HttpKernel\\HttpKernelInterface`
Expand Down