Skip to content

[Form] Deprecate "read_only" option #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 48 commits into from
Closed

[Form] Deprecate "read_only" option #3782

Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
d945ba2
[Form] Fix #9325
snoob Apr 9, 2014
8eae36d
Revert "[Form] Fix #9325"
snoob Apr 9, 2014
805c4bd
[WCM][Form] Deprecate "read_only" option
snoob Apr 9, 2014
1a587c5
Added February changelog
wouterj Mar 1, 2015
653ac94
fix changelog syntax
xabbuh Mar 2, 2015
515e87c
Merge branch '2.7'
weaverryan Mar 2, 2015
a2395ef
minor #5054 [Changelog] fix changelog syntax (xabbuh)
weaverryan Mar 2, 2015
feb621b
Merge branch '2.7'
weaverryan Mar 13, 2015
f24c84f
Merge branch '2.7'
weaverryan Mar 14, 2015
3fb0d42
Merge branch '2.7'
weaverryan Mar 15, 2015
7681e39
Merge branch '2.7'
weaverryan Mar 24, 2015
5dd50f5
Merge branch '2.7'
wouterj Apr 2, 2015
392398b
Merge branch '2.7'
wouterj Apr 4, 2015
56fe069
Merge branch '2.7'
wouterj Apr 5, 2015
e84182d
Added March changelog
wouterj Apr 5, 2015
c4e07cc
Merge branch '2.7'
wouterj Apr 7, 2015
2e86186
Merge branch '2.8'
weaverryan Apr 15, 2015
b74593c
Merge branch '2.8'
weaverryan Apr 17, 2015
701f2cf
Merge branch '2.8'
wouterj Apr 26, 2015
f0429d7
Merge branch '2.8'
weaverryan Apr 27, 2015
83636f0
Merge branch '2.8'
wouterj May 2, 2015
041b2af
Merge branch '2.8'
wouterj May 2, 2015
643f4c4
Merge branch '2.8'
wouterj May 2, 2015
c1cbb9a
Merge branch '2.8'
weaverryan May 3, 2015
de9b3d5
Merge branch '2.8'
wouterj May 10, 2015
25c9705
Merge branch '2.8'
wouterj May 17, 2015
12d8531
Merge branch '2.8'
weaverryan May 22, 2015
c2b92e1
Merge branch '2.8'
wouterj May 23, 2015
2d64dd5
Merge branch '2.8'
weaverryan May 23, 2015
7cadcdc
Merge branch '2.8'
wouterj May 24, 2015
c3fd4f5
Merge branch '2.8'
wouterj May 24, 2015
68f51df
Merge branch '2.8'
weaverryan May 25, 2015
0c089ec
Update create_form_type_extension.rst
May 28, 2015
78bab15
Merge branch '2.8'
weaverryan May 29, 2015
ed88e1c
bug #5328 Update create_form_type_extension.rst (jackdelin)
wouterj May 31, 2015
d6c5d5b
Merge branch '2.8'
wouterj May 31, 2015
6a9a26a
Merge branch '2.8'
wouterj May 31, 2015
f78cab7
Merge branch '2.8'
wouterj May 31, 2015
078bb2d
Merge branch '2.8'
wouterj Jun 7, 2015
f2f1ffc
[Form] Fix #9325
snoob Apr 9, 2014
e71355b
Revert "[Form] Fix #9325"
snoob Apr 9, 2014
897cf60
[WCM][Form] Deprecate "read_only" option
snoob Apr 9, 2014
46fa51f
Rebase
snoob Jun 10, 2015
2409c9d
Rebase
snoob Jun 10, 2015
c475f20
Rebase
snoob Jun 10, 2015
2055bbc
Fixed table
snoob Jun 12, 2015
8739ef1
Fixed typo
snoob Jun 15, 2015
677b6a8
Fixed typo
snoob Jun 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions reference/forms/twig_reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,6 @@ object:
+------------------------+-------------------------------------------------------------------------------------+
| ``value`` | The value that will be used when rendering (commonly the ``value`` HTML attribute). |
+------------------------+-------------------------------------------------------------------------------------+
| ``read_only`` | If ``true``, ``readonly="readonly"`` is added to the field. |
+------------------------+-------------------------------------------------------------------------------------+
| ``disabled`` | If ``true``, ``disabled="disabled"`` is added to the field. |
+------------------------+-------------------------------------------------------------------------------------+
| ``required`` | If ``true``, a ``required`` attribute is added to the field to activate HTML5 |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/birthday.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ option defaults to 120 years ago to the current year.
| | - `invalid_message`_ |
| | - `invalid_message_parameters`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks wrong (too many spaces).

+----------------------+-------------------------------------------------------------------------------+
| Parent type | :doc:`date </reference/forms/types/date>` |
+----------------------+-------------------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/checkbox.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if the box is unchecked, the value will be set to false.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

| | - `required`_ |
+-------------+------------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/choice.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ option.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here (actually all tables are broken)

| | - `required`_ |
+-------------+------------------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/country.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ you should just use the ``choice`` type directly.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+-----------------------------------------------------------------------+
| Parent type | :doc:`choice </reference/forms/types/choice>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/currency.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ you should just use the ``choice`` type directly.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+------------------------------------------------------------------------+
| Parent type | :doc:`choice </reference/forms/types/choice>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/date.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ day and year) or three select boxes (see the `widget`_ option).
| | - `invalid_message`_ |
| | - `invalid_message_parameters`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
+----------------------+-----------------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
+----------------------+-----------------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/datetime.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ the data can be a ``DateTime`` object, a string, a timestamp or an array.
| | - `invalid_message`_ |
| | - `invalid_message_parameters`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
+----------------------+-----------------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
+----------------------+-----------------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/email.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The ``email`` field is a text field that is rendered using the HTML5
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `max_length`_ (deprecated as of 2.5) |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-------------+---------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/entity.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ objects from the database.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+------------------------------------------------------------------+
| Parent type | :doc:`choice </reference/forms/types/choice>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/file.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The ``file`` type represents a file input in your form.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+---------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/form.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ on all types for which ``form`` is the parent type.
| | - `pattern`_ (deprecated as of 2.5) |
| | - `post_max_size_message`_ |
| | - `property_path`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-----------+--------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/integer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ integers. By default, all non-integer values (e.g. 6.78) will round down
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+-----------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/language.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ you should just use the ``choice`` type directly.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+------------------------------------------------------------------------+
| Parent type | :doc:`choice </reference/forms/types/choice>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/locale.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ you should just use the ``choice`` type directly.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+------------------------------------------------------------------------+
| Parent type | :doc:`choice </reference/forms/types/choice>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/money.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ how the input and output of the data is handled.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+---------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/number.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ that you want to use for your number.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+----------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
5 changes: 5 additions & 0 deletions reference/forms/types/options/read_only.rst.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
.. caution::

The ``read_only`` option has been deprecated and will be removed in 3.0.
Instead, use the ``attr`` option by setting it to an array with a ``readonly`` key.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block should be moved below the headline so that it fits inside the user's view port when the follow anchor refs.


read_only
~~~~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/password.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The ``password`` field renders an input password text box.
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `max_length`_ (deprecated as of 2.5) |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-------------+------------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/percent.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ This field adds a percentage sign "``%``" after the input box.
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+-----------------------------------------------------------------------+
| Parent type | :doc:`form </reference/forms/types/form>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/radio.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ If you want to have a boolean field, use :doc:`checkbox </reference/forms/types/
| | - `label`_ |
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
+-------------+---------------------------------------------------------------------+
| Parent type | :doc:`checkbox </reference/forms/types/checkbox>` |
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/search.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Read about the input search field at `DiveIntoHTML5.info`_
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `max_length`_ (deprecated as of 2.5) |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-------------+----------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/text.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The text field represents the most basic input text field.
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `max_length`_ (deprecated as of 2.5) |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-------------+--------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/textarea.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Renders a ``textarea`` HTML element.
| | - `label_attr`_ |
| | - `mapped`_ |
| | - `max_length`_ (deprecated as of 2.5) |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
| | - `required`_ |
| | - `trim`_ |
+-------------+------------------------------------------------------------------------+
Expand Down
2 changes: 1 addition & 1 deletion reference/forms/types/time.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ stored as a ``DateTime`` object, a string, a timestamp or an array.
| | - `invalid_message`_ |
| | - `invalid_message_parameters`_ |
| | - `mapped`_ |
| | - `read_only`_ |
| | - `read_only`_ (deprecated as of 2.8) |
+----------------------+-----------------------------------------------------------------------------+
| Parent type | form |
+----------------------+-----------------------------------------------------------------------------+
Expand Down
Loading