Skip to content

Update 'How to Create and store a Symfony2 Project in Git' #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2014
Merged

Update 'How to Create and store a Symfony2 Project in Git' #3827

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
011e0f0
Update .gitignore example
nicwortel May 3, 2014
34d61eb
Update the complete 'Initial Project Setup' paragraph
nicwortel May 4, 2014
6a19628
Indent the tip to be on the same level as the list item
nicwortel May 5, 2014
311f14b
Replace numbered list items with #
nicwortel May 5, 2014
32cee81
Small change in the wording
May 13, 2014
083c1f5
Replace static version constraint (2.4.4)
May 16, 2014
d9f72f9
Some refactoring of the article
May 16, 2014
6fd5e52
Small improvement
May 16, 2014
1baf7e0
Remove dash
May 19, 2014
3f3d886
Update the tip about the global .gitignore
May 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cookbook/workflow/new_project_git.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,16 @@ git repository:
.. code-block:: text

/web/bundles/
/app/bootstrap*
/app/bootstrap.php.cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is the case add the SymfonyRequirements class as sometimes is good to remove it or ignore it, same with config and check scripts 👶

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you put that comment on this line. Besides that, I'm missing what you want to say. The files listed here are things that generally should be ignored, ignoring config/check scripts is something that doesn't belong in that list imo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is more for more slim approaches, these files change anyway depending on the OS are are files that can be cleaned up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only changes the documentation to reflect the actual .gitignore. If you'd want to propose a change to the file, you should probably do it in the Symfony Standard Edition repository, not here.

/app/cache/*
/app/config/parameters.yml
/app/logs/*
!app/cache/.gitkeep
!app/logs/.gitkeep
/build/
/vendor/
/app/config/parameters.yml
/bin/
/composer.phar

.. tip::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it is not your mistake, could you please indent this tip to be on the same level as the rest of the list item? Then we can switch using #. for the list items, so we don't have to renumber them when we remove/add a new item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!


Expand Down