Added a note about the side effects of enabling both PHP and Twig #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Sep 12, 2014
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | #3293 |
|
|
||
| Enabling the ``php`` and ``twig`` template engines simultaneously is | ||
| allowed but it will produce an important side effect in your application: | ||
| template namespaces will no longer work:: |
There was a problem hiding this comment.
This should be a bit more precise. They will still work in places where you talk to Twig directly (for instance all places referencing a template from another one)
| .. caution:: | ||
|
|
||
| Enabling the ``php`` and ``twig`` template engines simultaneously is | ||
| allowed but it will produce an undesirable side effect in your application. |
|
Thanks Javier! Weird side-effect/bug - I don't really like it. But this is an edge-case for users, so I think it's ok. Cheers! |
weaverryan
added a commit
that referenced
this pull request
Sep 16, 2014
…and Twig (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added a note about the side effects of enabling both PHP and Twig | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #3293 Commits ------- fbbabb1 Reworded the explanation about the limitation of enablin PHP templates 5e47417 Improved the explanation thanks to @stof comments 3828162 Added a note about the side effects of enabling both PHP and Twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.