-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
add a note about apc for php recent versions #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apc is not required for php5.5+, I suggest to mention it to avoid people trying to install it on recent php versions
Not so sure, let's see what other doc maintainers think about this. |
`byte code caches`_ available, some of which are open source. The most widely | ||
used byte code cache is probably `APC`_ | ||
`byte code caches`_ available, some of which are open source. If you are using | ||
PHP 5.5 or more, the byte code cache is built-in into PHP runtime. For older versions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write:
If you are using PHP 5.5 or higher, the runtime has a built-in byte code cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested by @ip512 I think it's better to explicitly say "OPcache" instead of talking about an abstract "built-in byte code cache".
According to this documentation http://php.net/manual/en/intro.opcache.php, opcache is bundled in PHP starting from 5.5.0 version |
👍 for the rewrite |
@ip512 What do you think about also linking "built-in byte code cache" to the PHP documentation? |
maybe we could clarify things in this case : APC is replaced by OPCache, which is built-in into PHP runtime starting from 5.5 version. I think it's less confusing and will avoid people to try to install apc on PHP 5.5+ (for non PHP experts). The link could be placed on OPCache |
I think we should make a final effort to merge this rewording. I completely agree with @ip512: it's important to remind newcomers that they don't need to install APC if they use PHP 5.5+. |
Did the last missing changes in #5029 Thanks for starting this PR Grégory! |
…s (ip512, WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- Finish #4370: add a note about apc for php recent versions Finishes #4370 Original description: > apc is not required for php5.5+, I suggest to mention it to avoid people trying to install it on recent php versions | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | fixed tickets | - Commits ------- 95d09e9 Minor rewording bab2a29 add a note about apc for php recent versions
apc is not required for php5.5+, I suggest to mention it to avoid people trying to install it on recent php versions