Skip to content

Update the_controller.rst #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update the_controller.rst #4644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d50f0
Update the_controller.rst
teggen Dec 13, 2014
c101028
Update the_controller.rst
teggen Dec 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions quick_tour/the_controller.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ different controller using the ``forward()`` method::
public function indexAction()
{
return $this->forward('AppBundle:Blog:index', array(
'name' => $name
);
'name' => 'Fabien'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes! Could you please add a , after this line? Then we're ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comma after the last array element? Why so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the Symfony standard. This way, if a new item is added later on, you don't have to add a comma to the previous line (which will mess up the diff in the PR and it's something that's often forgotten).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense.

));
}
}

Expand Down