Skip to content

Fix representation #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2015
Merged

Fix representation #4703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d62349
Fix representation
ifdattic Dec 29, 2014
6a55617
Update forms.rst
ifdattic Dec 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion best_practices/forms.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Building Forms
Define your forms as PHP classes.

The Form component allows you to build forms right inside your controller
code. Honestly, unless you need to reuse the form somewhere else, that's
code. Honestly, if you don't need to reuse the form somewhere else, that's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original is more clear, but I see your point. How about:

And if you don't need to reuse the form in multiple places, that's totally fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it becomes a bit unclear where "that" is refering too. What about:

The Form component allows you to build forms right inside your controller code. This is
perfectly fine if you don't need to reuse the form somewhere else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it +1 from me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion! 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 should I change it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please

totally fine. But for organization and reuse, we recommend that you define each
form in its own PHP class::

Expand Down