Skip to content

[2.7] Removed 2.5 versionadded as its deprecated #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jan 4, 2015

No description provided.

@wouterj wouterj changed the title Removed 2.5 versionadded as its deprecated [2.7] Removed 2.5 versionadded as its deprecated Jan 4, 2015
@xabbuh
Copy link
Member

xabbuh commented Jan 4, 2015

If I don't misunderstand our workflow, this will only happen when 2.7 is actually released.


// ...
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you removed too much.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, my script has problems with code examples at the end of a file :)

@wouterj
Copy link
Member Author

wouterj commented Jan 5, 2015

@xabbuh see #4774 :

Remove all versionadded directives - and any other notes related to features changing or being new - for the version (e.g. 2.1) from the master branch. The result is that the next release (which is the first that comes entirely after the end of maintenance of this branch), will have no mentions of the old version (e.g. 2.1).

As 2.5 reaches end of maintance this month and 2.7 is released in May, it should not contain any versionadded directives for 2.5. Stricly spoken, we should merge this PR in january, but I think we can think ahead and merge it already.

@weaverryan
Copy link
Member

👍 then we can continue to clarify all of this on your issue - it's always been a little confusing (pretty sure I wrote these confusing-ish rules)

@weaverryan weaverryan merged commit 7d2f0f3 into symfony:2.7 Jan 16, 2015
weaverryan added a commit that referenced this pull request Jan 16, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed 2.5 versionadded as its deprecated

Commits
-------

7d2f0f3 Removed 2.5 versionadded as its deprecated
@wouterj wouterj deleted the remove-version-added-2.5 branch January 16, 2015 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants