Skip to content

Normalize excluded_404s in monolog cookbook #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2015
Merged

Conversation

jbafford
Copy link
Contributor

@jbafford jbafford commented Feb 6, 2015

Although excluded_404 works as a key in the configuration, the actual key MonologBundle looks for is excluded_404s. This makes it consistent with the php code block later in this file, and also in cookbook/logging/monolog_regex_based_excludes.html.

@stof
Copy link
Member

stof commented Feb 10, 2015

👍

@wouterj
Copy link
Member

wouterj commented Feb 14, 2015

👍 Thank you!

@wouterj wouterj merged commit 956a427 into symfony:2.3 Feb 14, 2015
wouterj added a commit that referenced this pull request Feb 14, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Normalize excluded_404s in monolog cookbook

Although excluded_404 works as a key in the configuration, the actual key MonologBundle looks for is excluded_404s. This makes it consistent with the php code block later in this file, and also in cookbook/logging/monolog_regex_based_excludes.html.

Commits
-------

956a427 Normalize excluded_404s in monolog cookbook
@jbafford jbafford deleted the patch-2 branch March 23, 2015 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants