Skip to content

Updated configuration for the new Asset component #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Updated configuration for the new Asset component #5170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d35177b
Updated configuration for the new Asset component
javiereguiluz Apr 13, 2015
690b6d5
Fixed a minor error
javiereguiluz Apr 13, 2015
22e73dd
Fixed the name of one label
javiereguiluz May 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reference/configuration/assetic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Full Default Configuration
some_filter: []
workers:
# see https://github.com/symfony/AsseticBundle/pull/119
# Cache can also be busted via the framework.templating.assets_version
# Cache can also be busted via the framework.assets.version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think a note should be added here as well? https://github.com/symfony/symfony/blob/2.7/UPGRADE-2.7.md I found a lot of changes are passing unreported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cordoval UPGRADE file should only contain breaking changes, CHANGELOG files of each component/bundle/bridge will contain all changes (including non-BC changes like this).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess i have misunderstood what breaking means then. This definitely broke his system 👴. But yeah it is not i guess in the BC promise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, as there is a BC layer: https://github.com/symfony/FrameworkBundle/blob/2.7/DependencyInjection/Configuration.php#L79-113 (triggering a deprecation notice is not breaking)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cordoval Can you give an example how this broke a system?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a ticket on symfony/symfony about this that I referenced it symfony/symfony#14332

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's no breaking change, but is a misconfiguration of the templating system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, but i see this happening more often, things are a bit cryptic for the people that is migrating to 2.7 since they have to be savvy in debugging things like this. I am cool either way, just pointing things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I agree - this should have been in the UPGRADE log (the change of the configuration). Strictly speaking, there are no BC breaks on minor version changes, so the UPGRADE log is for exactly stuff like this - big changes where some old way of doing something still works, but is deprecated (check out the Form section of UPGRADE-2.7.md). I've seen a few people complain about the asset stuff being missing from UPGRADE.

# setting - see the "framework" configuration section
cache_busting:
enabled: false
Expand Down
Loading