-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Documented the checkDNS option of the Url validator #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
75da2f3
[Validator] Updated documentation of URL validator
saro0h bb3dd4e
Simplified the first example and added more examples
javiereguiluz 1d3b192
Boolean -> boolean
javiereguiluz a2fd9ef
Fixed the order of the examples
javiereguiluz 5bcd48d
Added the "payload" option back (was removed by mistake)
javiereguiluz a04b4ac
Fixed some errors and made some simplifications
javiereguiluz 2becf60
Reordered the configuration blocks of the first example
javiereguiluz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ Validates that a value is a valid URL string. | |
+----------------+---------------------------------------------------------------------+ | ||
| Options | - `message`_ | | ||
| | - `protocols`_ | | ||
| | - `payload`_ | | ||
| | - `checkDNS`_ | | ||
+----------------+---------------------------------------------------------------------+ | ||
| Class | :class:`Symfony\\Component\\Validator\\Constraints\\Url` | | ||
+----------------+---------------------------------------------------------------------+ | ||
|
@@ -20,6 +20,14 @@ Basic Usage | |
|
||
.. configuration-block:: | ||
|
||
.. code-block:: yaml | ||
|
||
# src/Acme/BlogBundle/Resources/config/validation.yml | ||
Acme\BlogBundle\Entity\Author: | ||
properties: | ||
bioUrl: | ||
- Url: ~ | ||
|
||
.. code-block:: php-annotations | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
|
@@ -35,14 +43,6 @@ Basic Usage | |
protected $bioUrl; | ||
} | ||
|
||
.. code-block:: yaml | ||
|
||
# src/Acme/BlogBundle/Resources/config/validation.yml | ||
Acme\BlogBundle\Entity\Author: | ||
properties: | ||
bioUrl: | ||
- Url: ~ | ||
|
||
.. code-block:: xml | ||
|
||
<!-- src/Acme/BlogBundle/Resources/config/validation.xml --> | ||
|
@@ -84,13 +84,227 @@ message | |
|
||
This message is shown if the URL is invalid. | ||
|
||
.. configuration-block:: | ||
|
||
.. code-block:: yaml | ||
|
||
# src/Acme/BlogBundle/Resources/config/validation.yml | ||
Acme\BlogBundle\Entity\Author: | ||
properties: | ||
bioUrl: | ||
- Url: ~ | ||
message: The url "{{ value }}" is not a valid url. | ||
|
||
.. code-block:: php-annotations | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
/** | ||
* @Assert\Url( | ||
* message = "The url '{{ value }}' is not a valid url", | ||
* ) | ||
*/ | ||
protected $bioUrl; | ||
} | ||
|
||
.. code-block:: xml | ||
|
||
<!-- src/Acme/BlogBundle/Resources/config/validation.xml --> | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd"> | ||
|
||
<class name="Acme\BlogBundle\Entity\Author"> | ||
<property name="bioUrl"> | ||
<constraint name="Url"> | ||
<option name="message">The url "{{ value }}" is not a valid url.</option> | ||
</constraint> | ||
</property> | ||
</class> | ||
</constraint-mapping> | ||
|
||
.. code-block:: php | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Mapping\ClassMetadata; | ||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
public static function loadValidatorMetadata(ClassMetadata $metadata) | ||
{ | ||
$metadata->addPropertyConstraint('bioUrl', new Assert\Url(array( | ||
'message' => 'The url "{{ value }}" is not a valid url.', | ||
))); | ||
} | ||
} | ||
|
||
protocols | ||
~~~~~~~~~ | ||
|
||
**type**: ``array`` **default**: ``array('http', 'https')`` | ||
|
||
The protocols that will be considered to be valid. For example, if you also | ||
needed ``ftp://`` type URLs to be valid, you'd redefine the ``protocols`` | ||
array, listing ``http``, ``https`` and also ``ftp``. | ||
The protocols considered to be valid for the URL. For example, if you also consider | ||
the ``ftp://`` type URLs to be valid, redefine the ``protocols`` array, listing | ||
``http``, ``https``, and also ``ftp``. | ||
|
||
.. configuration-block:: | ||
|
||
.. code-block:: yaml | ||
|
||
# src/Acme/BlogBundle/Resources/config/validation.yml | ||
Acme\BlogBundle\Entity\Author: | ||
properties: | ||
bioUrl: | ||
- Url: ~ | ||
protocols: [http, https, ftp] | ||
|
||
.. code-block:: php-annotations | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
/** | ||
* @Assert\Url( | ||
* protocols = {"http", "https", "ftp"} | ||
* ) | ||
*/ | ||
protected $bioUrl; | ||
} | ||
|
||
.. code-block:: xml | ||
|
||
<!-- src/Acme/BlogBundle/Resources/config/validation.xml --> | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd"> | ||
|
||
<class name="Acme\BlogBundle\Entity\Author"> | ||
<property name="bioUrl"> | ||
<constraint name="Url"> | ||
<option name="protocols"> | ||
<value>http</value> | ||
<value>https</value> | ||
<value>ftp</value> | ||
</option> | ||
</constraint> | ||
</property> | ||
</class> | ||
</constraint-mapping> | ||
|
||
.. code-block:: php | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Mapping\ClassMetadata; | ||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
public static function loadValidatorMetadata(ClassMetadata $metadata) | ||
{ | ||
$metadata->addPropertyConstraint('bioUrl', new Assert\Url(array( | ||
'protocols' => array('http', 'https', 'ftp'), | ||
))); | ||
} | ||
} | ||
|
||
checkDNS | ||
~~~~~~~~ | ||
|
||
**type**: ``Boolean`` **default**: ``false`` | ||
|
||
By default, this constraint just validates the syntax of the given URL. If you | ||
also need to check whether the associated host exists, set the ``checkDNS`` | ||
option to ``true``: | ||
|
||
.. configuration-block:: | ||
|
||
.. code-block:: yaml | ||
|
||
# src/Acme/BlogBundle/Resources/config/validation.yml | ||
Acme\BlogBundle\Entity\Author: | ||
properties: | ||
bioUrl: | ||
- Url: ~ | ||
message: The url "{{ value }}" is not a valid url. | ||
protocols: [http, https] | ||
checkDNS: true | ||
|
||
.. code-block:: php-annotations | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
/** | ||
* @Assert\Url( | ||
* message = "The url '{{ value }}' is not a valid url", | ||
* protocols = {"http", "https"} | ||
* checkDNS = true | ||
* ) | ||
*/ | ||
protected $bioUrl; | ||
} | ||
|
||
.. code-block:: xml | ||
|
||
<!-- src/Acme/BlogBundle/Resources/config/validation.xml --> | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd"> | ||
|
||
<class name="Acme\BlogBundle\Entity\Author"> | ||
<property name="bioUrl"> | ||
<constraint name="Url"> | ||
<option name="message">The url "{{ value }}" is not a valid url.</option> | ||
<option name="protocols"> | ||
<value>http</value> | ||
<value>https</value> | ||
</option> | ||
<option name="checkDNS">true</option> | ||
</constraint> | ||
</property> | ||
</class> | ||
</constraint-mapping> | ||
|
||
.. code-block:: php | ||
|
||
// src/Acme/BlogBundle/Entity/Author.php | ||
namespace Acme\BlogBundle\Entity; | ||
|
||
use Symfony\Component\Validator\Mapping\ClassMetadata; | ||
use Symfony\Component\Validator\Constraints as Assert; | ||
|
||
class Author | ||
{ | ||
public static function loadValidatorMetadata(ClassMetadata $metadata) | ||
{ | ||
$metadata->addPropertyConstraint('bioUrl', new Assert\Url(array( | ||
'message' => 'The url "{{ value }}" is not a valid url.', | ||
'protocols' => array('http', 'https'), | ||
'checkDNS' => true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please align |
||
))); | ||
} | ||
} | ||
|
||
.. include:: /reference/constraints/_payload-option.rst.inc | ||
This option uses the :phpfunction:`checkdnsrr` PHP function to check the validity | ||
of the ``ANY`` DNS record corresponding to the host associated with the given URL. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Fixed. Thanks.