Skip to content

Docs do not match functionality #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Docs do not match functionality #6141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf7efa
Docs do not match functionality
Loupax Jan 13, 2016
42431c5
Changed text match suggestions
Loupax Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cookbook/bundles/configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,8 @@ The ``config:dump-reference`` command dumps the default configuration of a
bundle in the console using the Yaml format.

As long as your bundle's configuration is located in the standard location
(``YourBundle\DependencyInjection\Configuration``) and does not require
arguments to be passed to the constructor it will work automatically. If you
(``YourBundle\DependencyInjection\Configuration``) and does not extend
its constructor it will work automatically. If you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"extend" sounds strange when we talk about methods imo. What about saying something like "and does have a constructor"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works either way, I just used extend because this still works if the parent Configuration class has a __construct method itself.

Still I agree that "does not have a constructor" makes the meaning very clear. Waiting for any other feedback before changing the PR :)

have something different, your ``Extension`` class must override the
:method:`Extension::getConfiguration() <Symfony\\Component\\HttpKernel\\DependencyInjection\\Extension::getConfiguration>`
method and return an instance of your ``Configuration``.
Expand Down