[Validator] Add warning for null and blank values for minimum string length #6270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Validates that a given string length is *between* some minimum and maximum value. | ||
|
|
||
| **Warning**: *null* and *blank* values are not handled by this constraint. To | ||
| handle them, refers to the :doc:`/reference/constraints/Null`, |
There was a problem hiding this comment.
@xabbuh does this generic warning message is good for you? I would like to agree on the message in one place first before applying it everywhere needed.
There was a problem hiding this comment.
I would write it like "null and the empty string are not handled by this constraint. Additionally add the NotBlank or NotNull constraint to exclude these values."
There was a problem hiding this comment.
and then we should add it in a caution block
theofidry
force-pushed
the
validator-blank-null
branch
from
869f904 to
ef7976b
Compare
weaverryan
added a commit
that referenced
this pull request
Sep 24, 2017
…um string length (theofidry) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6270). Discussion ---------- [Validator] Add warning for null and blank values for minimum string length | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | symfony/symfony#16157 | Follow up of #5789. Summary of what has been said: even though the [Length#min](http://symfony.com/doc/current/reference/constraints/Length.html#min) option is well detailed and mention the case of `null` values, the introduction is still confusing: > Validates that a given string length is between some minimum and maximum value. As a result, a warning note is being added under this introduction. I've listed all the Symfony constraints. For some this `null` and `blank` values specificity has already been mentioned. I've noted the ones on which this warning does not apply, but for some I am not sure so it needs to be doubled checked. - Basic Contraints - [x] NotBlank: already done - [x] Blank: already done - [x] NotNull: already done - [x] IsNull: already done - ~~[ ] IsTrue~~ - ~~[ ] IsFalse~~ - ~~[ ] Type~~ - String Constraints¶ - ~~[ ] Email~~ - [x] Length - ~~[ ] Url~~ - ~~[ ] Regex~~ - ~~[ ] Ip~~ - ~~[ ] Uuid~~ - Number Constraints¶ - [ ] Range - Comparison Constraints¶ - ~~[ ] EqualTo~~ - ~~[ ] NotEqualTo~~ - ~~[ ] IdenticalTo~~ - ~~[ ] NotIdenticalTo~~ - [ ] LessThan: needed? How `@Assert\LessThan("-18 years")` behaves if the value is null? - [ ] LessThanOrEqual: same as `LessThan` - [ ] GreaterThan: same as `LessThan` - [ ] GreaterThanOrEqual: same as `LessThan` - Date Constraints¶ - ~~[ ] Date~~ - ~~[ ] DateTime~~ - ~~[ ] Time~~ - Collection Constraints¶ - ~~[ ] Choice~~ - ~~[ ] Collection~~ - ~~[ ] Count~~ - ~~[ ] UniqueEntity~~ - ~~[ ] Language~~ - ~~[ ] Locale~~ - ~~[ ] Country~~ - File Constraints¶ - ~~[ ] File~~ - ~~[ ] Image~~ - Financial and other Number Constraints¶ - ~~[ ] Bic~~ - ~~[ ] CardScheme~~ - ~~[ ] Currency~~ - ~~[ ] Luhn~~ - ~~[ ] Iban~~ - ~~[ ] Isbn~~ - ~~[ ] Issn~~ - Other Constraints¶ - ~~[ ] Callback~~ - ~~[ ] Expression~~ - ~~[ ] All~~ - ~~[ ] UserPassword~~ - ~~[ ] Valid~~ Commits ------- 38d44c2 [Validator] Add warning for null and blank values for minimum string length
weaverryan
added a commit
that referenced
this pull request
Sep 24, 2017
|
Thanks @theofidry! I've made the final changes. And yes I believe this problem extends also to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #5789.
Summary of what has been said: even though the Length#min option is well detailed and mention the case of
nullvalues, the introduction is still confusing:As a result, a warning note is being added under this introduction.
I've listed all the Symfony constraints. For some this
nullandblankvalues specificity has already been mentioned. I've noted the ones on which this warning does not apply, but for some I am not sure so it needs to be doubled checked.[ ] IsTrue[ ] IsFalse[ ] Type[ ] Email[ ] Url[ ] Regex[ ] Ip[ ] Uuid[ ] EqualTo[ ] NotEqualTo[ ] IdenticalTo[ ] NotIdenticalTo@Assert\LessThan("-18 years")behaves if the value is null?LessThanLessThanLessThan[ ] Date[ ] DateTime[ ] Time[ ] Choice[ ] Collection[ ] Count[ ] UniqueEntity[ ] Language[ ] Locale[ ] Country[ ] File[ ] Image[ ] Bic[ ] CardScheme[ ] Currency[ ] Luhn[ ] Iban[ ] Isbn[ ] Issn[ ] Callback[ ] Expression[ ] All[ ] UserPassword[ ] Valid