Skip to content

[book] bundle and config ch changes #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[book] bundle and config ch changes #6271

wants to merge 4 commits into from

Conversation

talitakz
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets x

Added "Configuration Formats", "Configuration Files of the Symfony Standard Edition"
ans ""Creating Custom Environments"" subtitles
Completele restructures "Environemtns" subtitle. Created more subtitles out of one.

* Doctrine Mapping: Annotations, YAML, XML, PHP

* Translation: XML, YAML, PHP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely convinced we should add this section - I hate to have extra details at the top of an article. I think we should at least remove this last part (starting with The supported formats...) - and maybe the description of the 4 formats above that (but I'm less sure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a Configuration chapter i thought it would be convenient to include this information. At this moment this info is present only in http://symfony.com/doc/current/contributing/documentation/standards.html. Actually in my humble personal opinion this information should be present in some earlier chapter of the book. Since this part of the documentation is called "the book" it would be logical to include this before the first examples and encounter of different formats - some programmers who might be just learning about Symfony could decide to read this "book" as a book - from 1st chapter to the last - and it would make sense to have this information at the beginning.

@wouterj, @stof could i get your opinion on this? Thank you.

@talitakz talitakz changed the title Book bundle config modif [book] bundle and config ch changes Mar 12, 2016
@weaverryan
Copy link
Member

Closing: see #6252 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants