Skip to content

[book] SC and validation ch changes #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[book] SC and validation ch changes #6272

wants to merge 5 commits into from

Conversation

talitakz
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets x

@javiereguiluz
Copy link
Member

@paxyknox thanks for proposing these improvements. The lack of feedback from reviewers is probably due to the huge set of changes. If there are a lot of changes, next time is better to change just one chapter per pull request.

Before reviewing in detail, I think we should revert all the changes related to titles and headings. The main reason is that these changes break all the existing links (we can prevent this adding some hidden labels, but is a bit boring to do so). Besides, the new doc search engine is able to return good results without adding these words to the section titles.

But before doing any change, let's wait for the opinion of our doc managers @xabbuh and @wouterj.

@talitakz
Copy link
Contributor Author

At this point i should probably explain the proposed changes. When I decided to read through these two chapters and propose changes I didn't just looked at chapters as they are but I looked how they are placed in the book as a whole. I tried to determine what a person who might decide to read the book from the beginning to the end would already know then they would hit "Service container" and "Validation" chapters.. So concerning the content - nothing was removed(!) just reordered for a better word and content flow.

Yes. I agree. We should wait for the opining of the doc managers @xabbuh and @wouterj.

@xabbuh
Copy link
Member

xabbuh commented Feb 20, 2016

I need to find some time to review this as this is really a lot of changes. On the first glance they look good but I need to do some deeper reviewing. I cannot promise when I will have the time to do the review but please feel free to ping me if I forget about it.

@talitakz
Copy link
Contributor Author

Ping ;) Just a friendly reminder. This yet needs to be reviewed.

@talitakz talitakz changed the title [book] changes in SC and Validation ch. [book]SC and validation ch changes Mar 12, 2016
@talitakz talitakz changed the title [book]SC and validation ch changes [book] SC and validation ch changes Mar 12, 2016
@weaverryan
Copy link
Member

Closing: see #6252 (comment)

@weaverryan weaverryan closed this Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants